Work around TLS 1.2 requirement #6689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The changed line broke some time this morning; most Windows Powershell instances default to TLS 1.1 and will thus fail with `wget : The underlying connection was closed: An unexpected error occurred on a send.` trying to run the previous command.
Deleted additional install-script args when testing my change
bergmeister
reviewed
Jul 27, 2018
There was a problem hiding this comment.
A simpler solution would be:
-`@powershell -NoProfile -ExecutionPolicy unrestricted -Command "&([scriptblock]::Create(([Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12; Invoke-WebRequest -useb 'https://dot.net/v1/dotnet-install.ps1'))) <additional install-script args>"`I do not see the need of creating and invoking the scriptblock
|
@johnbeisner can you take a look at this please? |
|
Tested successfully: |
johnbeisner
approved these changes
Jul 31, 2018
|
@mairaw can't be merged until I think you approve? |
mairaw
approved these changes
Jul 31, 2018
|
Done @MattGal. Yes, one of the writers has to approve. 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changed line broke some time this morning; most Windows Powershell instances default to TLS 1.1 and will thus fail with
wget : The underlying connection was closed: An unexpected error occurred on a send.trying to run the previous command.Summary
https://dot.net has been moved to TLS 1.2 only, some docs don't account for this.
Fixes Problem bootstrapping .NET