Skip to content

Replacing built-in types with keywords in one big PR #6920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
WhiteBlackGoose opened this issue Jul 24, 2021 · 7 comments
Open

Replacing built-in types with keywords in one big PR #6920

WhiteBlackGoose opened this issue Jul 24, 2021 · 7 comments
Labels
area-Infrastructure Pri3 Indicates issues/PRs that are low priority untriaged New issue has not been triaged by the area owner

Comments

@WhiteBlackGoose
Copy link
Contributor

As answered here, it is a good idea to replace built-in types with keywords, when those exist (e. g. System.String -> string). It is a very pritimitive change, so here's my question: can I do it in one PR?
@PRMerger18 PRMerger18 added the Pri3 Indicates issues/PRs that are low priority label Jul 24, 2021
@dotnet-bot dotnet-bot added the untriaged New issue has not been triaged by the area owner label Jul 24, 2021
@ghost ghost added the area-Infrastructure label Jul 24, 2021
@WhiteBlackGoose
Copy link
Contributor Author

Alternative: I can create a number (20-200) PRs of moderate size to perform these changes. Another alternative: not to do it at all (but it should be done eventually!)

@BillWagner
Copy link
Member

@WhiteBlackGoose

Alternative: I can create a number (20-200) PRs of moderate size to perform these changes.

If you're interested in doing that, we'll watch for them and merge them. Thank you!

WhiteBlackGoose added a commit to WhiteBlackGoose/dotnet-api-docs that referenced this issue Jul 26, 2021
@WhiteBlackGoose
Names -> Keywords
9835b44 
Replacing full type names with keywords when appropriate        Files affected: NoFind1.cs, rank1.cs, bytelength.cs, source.cs, codedomgenerics.cs, dictionarybase.cs, source2.cs, nocb_basegetall.cs, program.cs, rethrow1.cs, rethrow3.cs, properties.cs, ToStringEx1.cs, example1.cs, Expression.cs, program.cs, gut.cs, eq.cs, array1.cs, gettype1.cs, assembly.cs, source4.cs, source.cs, remarks.cs.        See dotnet#6920
WhiteBlackGoose added a commit to WhiteBlackGoose/dotnet-api-docs that referenced this issue Jul 26, 2021
@WhiteBlackGoose
Names -> Keywords
68cc4e3 
Replacing full type names with keywords when appropriate        Files affected: Program.cs, Program.cs, Program.cs.        See dotnet#6920
WhiteBlackGoose added a commit to WhiteBlackGoose/dotnet-api-docs that referenced this issue Jul 26, 2021
@WhiteBlackGoose
Names -> Keywords
98b9103 
Replacing full type names with keywords when appropriate        Files affected: Program.cs, MetadataReaderSnippets.cs, example1.cs, parseexact-iso8601-2.cs, parseexact-iso8601.cs.        See dotnet#6920
WhiteBlackGoose added a commit to WhiteBlackGoose/dotnet-api-docs that referenced this issue Jul 26, 2021
@WhiteBlackGoose
Names -> Keywords
29a0041 
Replacing full type names with keywords when appropriate        Files affected: tryparseexacto8601-2.cs, Program.cs, Program.cs, Calendar.cs, Instantiation.cs.        See dotnet#6920
WhiteBlackGoose added a commit to WhiteBlackGoose/dotnet-api-docs that referenced this issue Jul 26, 2021
@WhiteBlackGoose
Names -> Keywords
4b8af5a 
Replacing full type names with keywords when appropriate        Files affected: Parsing.cs, Persistence.cs.        See dotnet#6920
WhiteBlackGoose added a commit to WhiteBlackGoose/dotnet-api-docs that referenced this issue Jul 26, 2021
@WhiteBlackGoose
Names -> Keywords
a36c37c 
Replacing full type names with keywords when appropriate        Files affected: Program.cs, Resolution.cs, StringFormat.cs, identify.cs, intro.cs, options.cs.        See dotnet#6920
WhiteBlackGoose added a commit to WhiteBlackGoose/dotnet-api-docs that referenced this issue Jul 26, 2021
@WhiteBlackGoose
Names -> Keywords
290ca4d 
Replacing full type names with keywords when appropriate        Files affected: split2.cs, stringsplit2.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs.        See dotnet#6920
WhiteBlackGoose added a commit to WhiteBlackGoose/dotnet-api-docs that referenced this issue Jul 26, 2021
@WhiteBlackGoose
Names -> Keywords
ba010e1 
Replacing full type names with keywords when appropriate        Files affected: source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs.        See dotnet#6920
WhiteBlackGoose added a commit to WhiteBlackGoose/dotnet-api-docs that referenced this issue Jul 26, 2021
@WhiteBlackGoose
Names -> Keywords
a2db5c1 
Replacing full type names with keywords when appropriate        Files affected: source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs.        See dotnet#6920
WhiteBlackGoose added a commit to WhiteBlackGoose/dotnet-api-docs that referenced this issue Jul 26, 2021
@WhiteBlackGoose
Names -> Keywords
5ad5015 
Replacing full type names with keywords when appropriate        Files affected: Program.cs, Program.cs, Program.cs, Instantiation.cs, Parsing.cs, Resolution.cs, options.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, mysample.cs, source.cs, source.cs.        See dotnet#6920
WhiteBlackGoose added a commit to WhiteBlackGoose/dotnet-api-docs that referenced this issue Jul 26, 2021
@WhiteBlackGoose
Names -> Keywords
9129ffb 
Replacing full type names with keywords when appropriate        Files affected: source.cs, source.cs, source.cs, source.cs, source.cs, Form1.cs, Form1.cs, source.cs.        See dotnet#6920
WhiteBlackGoose added a commit to WhiteBlackGoose/dotnet-api-docs that referenced this issue Jul 26, 2021
@WhiteBlackGoose
Names -> Keywords
ed6ac87 
Replacing full type names with keywords when appropriate        Files affected: Program.cs, Program.cs, Program.cs, Parsing.cs, Resolution.cs, options.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, mysample.cs, source.cs, source.cs, source.cs.        See dotnet#6920
WhiteBlackGoose added a commit to WhiteBlackGoose/dotnet-api-docs that referenced this issue Jul 26, 2021
@WhiteBlackGoose
Names -> Keywords
31c27b9 
Replacing full type names with keywords when appropriate        Files affected: source.cs, source.cs, source.cs, source.cs, Form1.cs, Form1.cs, source.cs.        See dotnet#6920
WhiteBlackGoose added a commit to WhiteBlackGoose/dotnet-api-docs that referenced this issue Jul 26, 2021
@WhiteBlackGoose
Names -> Keywords
7132683 
Replacing full type names with keywords when appropriate        Files affected: customcontrol.cs, CustomUpdatePanel.cs, customer.cs, service.cs, source.cs, formatter.cs, wsdldocumentationattribute.cs, program.cs, snippets.cs, creationendpointelement.cs, services.cs, overview.cs, source.cs, overview.cs, ierrorhandler.cs, extensiontypes.cs, services.cs, source.cs, services.cs, services.cs, client.cs, services.cs, operationinfosnippets.cs.        See dotnet#6920
WhiteBlackGoose added a commit to WhiteBlackGoose/dotnet-api-docs that referenced this issue Jul 26, 2021
@WhiteBlackGoose
Names -> Keywords
fdb53e6 
Replacing full type names with keywords when appropriate        Files affected: customer.cs, httpclient.cs, messagebasedcustomerservice.cs, source.cs, snippets.cs, instance.cs, service.cs, program.cs, order.cs, wholeenchilada.cs.        See dotnet#6920
WhiteBlackGoose added a commit to WhiteBlackGoose/dotnet-api-docs that referenced this issue Jul 26, 2021
@WhiteBlackGoose
Names -> Keywords
abfacef 
Replacing full type names with keywords when appropriate        Files affected: Program.cs, Program.cs, Program.cs, Parsing.cs, Resolution.cs, options.cs, split2.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, mysample.cs.        See dotnet#6920
WhiteBlackGoose added a commit to WhiteBlackGoose/dotnet-api-docs that referenced this issue Jul 26, 2021
@WhiteBlackGoose
Names -> Keywords
26e361b 
Replacing full type names with keywords when appropriate        Files affected: source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, Form1.cs, Form1.cs, source.cs, source.cs, source.cs.        See dotnet#6920
WhiteBlackGoose added a commit to WhiteBlackGoose/dotnet-api-docs that referenced this issue Jul 26, 2021
@WhiteBlackGoose
Names -> Keywords
23c7ee7 
Replacing full type names with keywords when appropriate        Files affected: source.cs, Program.cs.        See dotnet#6920
WhiteBlackGoose added a commit to WhiteBlackGoose/dotnet-api-docs that referenced this issue Jul 26, 2021
@WhiteBlackGoose
Names -> Keywords
e5b8e95 
Replacing full type names with keywords when appropriate        Files affected: source.cs.        See dotnet#6920
WhiteBlackGoose added a commit to WhiteBlackGoose/dotnet-api-docs that referenced this issue Jul 26, 2021
@WhiteBlackGoose
Names -> Keywords
62ade6a 
Replacing full type names with keywords when appropriate        Files affected: customcontrol.cs, CustomUpdatePanel.cs, customer.cs, service.cs, source.cs, formatter.cs, wsdldocumentationattribute.cs, program.cs, program.cs, snippets.cs, creationendpointelement.cs, services.cs, overview.cs, source.cs, overview.cs, snippets.cs, ierrorhandler.cs, extensiontypes.cs, services.cs, source.cs, services.cs, services.cs, client.cs.        See dotnet#6920
WhiteBlackGoose added a commit to WhiteBlackGoose/dotnet-api-docs that referenced this issue Jul 26, 2021
@WhiteBlackGoose
Names -> Keywords
291efdd 
Replacing full type names with keywords when appropriate        Files affected: services.cs, operationinfosnippets.cs, customer.cs, httpclient.cs, messagebasedcustomerservice.cs, source.cs, program.cs, snippets.cs, instance.cs.        See dotnet#6920
WhiteBlackGoose added a commit to WhiteBlackGoose/dotnet-api-docs that referenced this issue Jul 26, 2021
@WhiteBlackGoose
Names -> Keywords
4d3fcf1 
Replacing full type names with keywords when appropriate

Files affected: Program.cs, service.cs, program.cs, order.cs, wholeenchilada.cs, chunkingreader.cs, timeouthelper.cs, timeouthelper.cs, timeouthelper.cs, order.cs, service.cs, program.cs, client.cs, client.cs, servicesnippets.cs, source.cs, service.cs, source.cs, program.cs.

See dotnet#6920
WhiteBlackGoose added a commit to WhiteBlackGoose/dotnet-api-docs that referenced this issue Jul 26, 2021
@WhiteBlackGoose
Names -> Keywords
a87f91e 
Replacing full type names with keywords when appropriate

Files affected: service.cs, service.cs, program.cs, order.cs, source.cs, services.cs, services.cs, snippets.cs.

See dotnet#6920
WhiteBlackGoose added a commit to WhiteBlackGoose/dotnet-api-docs that referenced this issue Jul 26, 2021
@WhiteBlackGoose
Names -> Keywords
4299a3f 
Replacing full type names with keywords when appropriate

Files affected: sqlpersistenceproviderfactory.cs, mytokenauthenticator.cs, ioutlook.cs, snippets.cs, snippets1.cs, snippets24.cs, program.cs, program.cs, source.cs.

See dotnet#6920
@WhiteBlackGoose
Copy link
Contributor Author

Oops XD

WhiteBlackGoose added a commit to WhiteBlackGoose/dotnet-api-docs that referenced this issue Jul 26, 2021
@WhiteBlackGoose
Names -> Keywords
10d0293 
Replacing full type names with keywords when appropriate

Files affected: errorproviderexample.cs, form1.cs, Form1.cs, Form1.cs.

See dotnet#6920
WhiteBlackGoose added a commit to WhiteBlackGoose/dotnet-api-docs that referenced this issue Jul 26, 2021
@WhiteBlackGoose
Names -> Keywords
43c1a7c 
Replacing full type names with keywords when appropriate

Files affected: Form1.cs, form1.cs, listviewgroupsexample.cs, Form1.cs, soundtestform.cs, Form1.cs, Form1.cs, Form1.cs, Form1.cs, form1.cs, form1.cs, form1.cs, form1.cs, ToolStripRadioButtonMenuItem.cs, treenode_bounds.cs, treeviewcustomization.cs, treeviewdragdrop.cs, treeviewownerdraw.cs, treeviewshowcheckednodes1.cs, treeviewshowcheckednodes2.cs.

See dotnet#6920
WhiteBlackGoose added a commit to WhiteBlackGoose/dotnet-api-docs that referenced this issue Jul 26, 2021
@WhiteBlackGoose
Names -> Keywords
34ad52a 
Replacing full type names with keywords when appropriate

Files affected: WB2.cs, WebBrowserMisc.cs, winformsedserviceeditordialogexample.cs, winformsedserviceeditordropdownexample.cs, Misc3DOperationsExample.cs, Page1.xaml.cs, Program.cs, MyConverter.cs, MyData.cs, data.cs, Data.cs, AgeRangeRule.cs, Window1.xaml.cs.

See dotnet#6920
WhiteBlackGoose added a commit to WhiteBlackGoose/dotnet-api-docs that referenced this issue Jul 26, 2021
@WhiteBlackGoose
Names -> Keywords
525134d 
Replacing full type names with keywords when appropriate

Files affected: MyData.cs, DoubleToStringConverter.cs, Window1.xaml.cs, Window1.xaml.cs, page1.xaml.cs, Window1.xaml.cs, Window1.xaml.cs, DateConverter.cs, window1.xaml.cs, Program.cs, billsdata.cs, HtmlCssParser.cs, HtmlFromXamlConverter.cs, HtmlLexicalAnalyzer.cs.

See dotnet#6920
WhiteBlackGoose added a commit to WhiteBlackGoose/dotnet-api-docs that referenced this issue Jul 26, 2021
@WhiteBlackGoose
Names -> Keywords
8c62196 
Replacing full type names with keywords when appropriate

Files affected: HtmlParser.cs, HtmlToXamlConverter.cs, Util.cs, WordXmlReader.cs, WordXmlWriter.cs, Window1.xaml.cs, Window1.xaml.cs, SearchWindow.cs, Window1.xaml.cs, Window1.xaml.cs, data.cs.

See dotnet#6920
WhiteBlackGoose added a commit to WhiteBlackGoose/dotnet-api-docs that referenced this issue Jul 26, 2021
@WhiteBlackGoose
Names -> Keywords
8a42ade 
Replacing full type names with keywords when appropriate

Files affected: PixelFormatsExample.cs, Window1.xaml.cs, mainwindow.xaml.cs, DataSource.cs, PackageDigitalSignature.cs, GetStringPageFunction.xaml.cs, GetStringPageFunctionCaller.xaml.cs, data.cs, Window1.xaml.cs, Window1.xaml.cs, Window1.xaml.cs, PointExample.cs.

See dotnet#6920
WhiteBlackGoose added a commit to WhiteBlackGoose/dotnet-api-docs that referenced this issue Jul 26, 2021
@WhiteBlackGoose
Names -> Keywords
47371de 
Replacing full type names with keywords when appropriate

Files affected: Program.cs, PrintServerCreate.cs, printticket.cs, Form1.cs, Window1.xaml.cs, Class1.cs, Window1.xaml.cs, Pane1.xaml.cs, Window1.xaml.cs, Window1.xaml.cs, Window1.xaml.cs.

See dotnet#6920
WhiteBlackGoose added a commit to WhiteBlackGoose/dotnet-api-docs that referenced this issue Jul 26, 2021
@WhiteBlackGoose
Names -> Keywords
29d7712 
Replacing full type names with keywords when appropriate

Files affected: Window1.xaml.cs, Window1.xaml.cs, Window1.xaml.cs, ClientForm.cs, ListFragment.cs, ListItemFragment.cs, ValueFragment.cs, UIASelectionItemPattern_snippets.cs, SearchWindow.cs.

See dotnet#6920
WhiteBlackGoose added a commit to WhiteBlackGoose/dotnet-api-docs that referenced this issue Jul 26, 2021
@WhiteBlackGoose
Names -> Keywords
fe6ec98 
Replacing full type names with keywords when appropriate

Files affected: UIAValuePattern_snippets.cs, Window1.xaml.cs, Window1.xaml.cs, VectorExample.cs, Window1.xaml.cs, XpsCreate.cs, Window1.xaml.cs, WpfContent.cs, XpsPrintHelper.cs.

See dotnet#6920
WhiteBlackGoose added a commit to WhiteBlackGoose/dotnet-api-docs that referenced this issue Jul 26, 2021
@WhiteBlackGoose
Names -> Keywords
ce0646d 
Replacing full type names with keywords when appropriate

Files affected: ReadingAndWritingXps.cs, Window1.xaml.cs, Window1.xaml.cs, XpfContent.cs, XpsSaveHelper.cs.

See dotnet#6920
@WhiteBlackGoose
Copy link
Contributor Author

WhiteBlackGoose commented Jul 26, 2021 •
edited
Loading

Alright, the program's finished. It will be 170 PRs in total (like I said). Is it still better to keep a lot of PRs instead of one big? Especially given that the change is not that important and doesn't require very careful review.

I can also open 20x bigger PRs but 8-9 instead of 170.

@safern
Copy link
Member

safern commented Aug 2, 2021

FYI: @gewarren

BillWagner pushed a commit that referenced this issue Aug 4, 2021
@WhiteBlackGoose
Names -> Keywords (#6925)
69abc1b 
Replacing full type names with keywords when appropriate

Files affected: service.cs, service.cs, program.cs, order.cs, source.cs, services.cs, services.cs, snippets.cs.

See #6920
BillWagner pushed a commit that referenced this issue Aug 4, 2021
@WhiteBlackGoose
Names -> Keywords batch 2 (#6926)
bb7dd3c 
* Names -> Keywords

Replacing full type names with keywords when appropriate

Files affected: sqlpersistenceproviderfactory.cs, mytokenauthenticator.cs, ioutlook.cs, snippets.cs, snippets1.cs, snippets24.cs, program.cs, program.cs, source.cs.

See #6920

* Consistency in comments fixed
BillWagner pushed a commit that referenced this issue Aug 4, 2021
@WhiteBlackGoose
Names -> Keywords (#6928)
ad41401 
Replacing full type names with keywords when appropriate

Files affected: source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs.

See #6920
BillWagner pushed a commit that referenced this issue Aug 4, 2021
@WhiteBlackGoose
Names -> Keywords batch 5 (#6929)
a3733d8 
* Names -> Keywords

Replacing full type names with keywords when appropriate

Files affected: source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs.

See #6920

* Example reverted

* Example reverted
BillWagner pushed a commit that referenced this issue Aug 4, 2021
@WhiteBlackGoose
Names -> Keywords (#6930)
872ec1e 
Replacing full type names with keywords when appropriate

Files affected: source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, action.cs, Action3.cs, Anon.cs, Delegate.cs, Lambda.cs, Action4.cs.

See #6920
BillWagner pushed a commit that referenced this issue Aug 4, 2021
@WhiteBlackGoose
Names -> Keywords batch 8 (#6932)
5f55fbb 
* Names -> Keywords

Replacing full type names with keywords when appropriate

Files affected: BadSearch.cs, EmptyString1.cs, Enumerator1.cs, FindWords1.cs, NoElements.cs, NoFind1.cs, NoFind2.cs, OOR1.cs, OOR2.cs, Race1.cs.

See #6920

* Update NoFind1.cs
BillWagner pushed a commit that referenced this issue Aug 4, 2021
@WhiteBlackGoose
Names -> Keywords (#6933)
a7cecbc 
Replacing full type names with keywords when appropriate

Files affected: Race2.cs, arrayasreadonly.cs, exists1.cs, exists2.cs, trueforall1.cs, trueforall2.cs, example1.cs, arraysegment.cs, stringlib.cs, example1.cs, bitstodbl.cs, toint32.cs, binary1.cs, format3.cs.

See #6920
BillWagner pushed a commit that referenced this issue Aug 4, 2021
@WhiteBlackGoose
Names -> Keywords (#6927)
f6abd08 
Replacing full type names with keywords when appropriate

Files affected: source3.cs, source.cs, source.cs, source.cs, source2.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs, source.cs.

See #6920
BillWagner added a commit that referenced this issue Aug 4, 2021
@WhiteBlackGoose @BillWagner
Names -> Keywords batch 7 (#6931)
dd22df7 
* Names -> Keywords

Replacing full type names with keywords when appropriate

Files affected: Anon.cs, Delegate.cs, Lambda.cs, createinstance2.cs, CreateInstance5.cs, Example4.cs, Example6.cs, Example8.cs, ForConsumers1.cs, GetSwitches3.cs.

See #6920

* An example reverted

* An example reverted

Co-authored-by: Bill Wagner <[email protected]>
This was referenced Aug 4, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-Infrastructure Pri3 Indicates issues/PRs that are low priority untriaged New issue has not been triaged by the area owner
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@BillWagner @dotnet-bot @safern @PRMerger18 @WhiteBlackGoose