Skip to content

Add documentation for JsonConstructorAttribute #4014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

layomia
Copy link
Contributor

@layomia layomia commented Mar 20, 2020

Summary

Add documentation for JsonConstructorAttribute added in dotnet/runtime#33444.

@layomia layomia self-assigned this Mar 20, 2020
@dotnet-bot dotnet-bot added this to the March 2020 milestone Mar 20, 2020
@layomia layomia closed this Mar 20, 2020
@layomia layomia reopened this Mar 20, 2020
@carlossanlop
Copy link
Contributor

@layomia adding the file yourself is not the correct way to get this file to show up in Docs.

The assembly reference containing this type needs to be sent by our team to the Docs team, and the Docs build system needs to generate this xml file automatically. After that happens, then you can edit the file (add the new documentation).

@safern @BillWagner when was the last ref assembly update we made? Was this type included in that update? If not, can we get another update?

@safern
Copy link
Member

safern commented Mar 24, 2020

The last ref drop we provided is preview1 which doesn't contain this change. It seems like this change will be contained in preview3.

@layomia
Copy link
Contributor Author

layomia commented Mar 25, 2020

I see. I'll open a new PR when the changes flow to the docs. Thanks

@layomia layomia closed this Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants