-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Remove refs to Windows 9x #5453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each of the API in xml/System.Windows.Forms/SystemInformation.xml need to be cross checked against Win32 definitions (most, if not all, in WinUser.h). Some of the API are supported as far back as W2000 or XP.
At the moment this looks confusing - we're removing some notes completely (which note support from W2000/XP onwards), yet we're removing some other comments stating the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM @gewarren
You can when ready.
> This property is supported only on Windows NT 4.0 SP4 or later, Windows 98, Windows Millennium Edition, Windows 2000, Windows XP, and the Windows Server 2003 family. | ||
|
||
|
||
> This property is supported only on Windows NT 4.0 SP4 or later, Windows 2000, Windows XP, and the Windows Server 2003 family. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still support any of these? Or should the whole sentence be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and similar notes must be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change, @gewarren! There are some suggestions for you to consider.
cc @danmoseley who raised the question of having old OS mentions removed from Docs.
Fixes #2053