Skip to content

Add note about Drawing on non-Windows OS #7023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 16, 2021
Merged

Add note about Drawing on non-Windows OS #7023

merged 2 commits into from
Aug 16, 2021

Conversation

gewarren
Copy link
Contributor

Replaces #6944, which was later reverted by #7020.

@gewarren gewarren added the 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) label Aug 10, 2021
@ghost ghost added the area-Infrastructure label Aug 10, 2021
@opbld32
Copy link

opbld32 commented Aug 10, 2021

Docs Build status updates of commit 86d32a6:

✅ Validation status: passed

File Status Preview URL Details
includes/system-drawing-common.md ✅Succeeded View
xml/System.Drawing.Drawing2D/AdjustableArrowCap.xml ✅Succeeded View
xml/System.Drawing.Drawing2D/CustomLineCap.xml ✅Succeeded View
xml/System.Drawing.Drawing2D/GraphicsPath.xml ✅Succeeded View
xml/System.Drawing.Drawing2D/GraphicsPathIterator.xml ✅Succeeded View
xml/System.Drawing.Drawing2D/GraphicsState.xml ✅Succeeded View
xml/System.Drawing.Drawing2D/HatchBrush.xml ✅Succeeded View
xml/System.Drawing.Drawing2D/LinearGradientBrush.xml ✅Succeeded View
xml/System.Drawing.Drawing2D/Matrix.xml ✅Succeeded View
xml/System.Drawing.Drawing2D/PathGradientBrush.xml ✅Succeeded View
xml/System.Drawing.Imaging/Encoder.xml ✅Succeeded View
xml/System.Drawing.Imaging/EncoderParameter.xml ✅Succeeded View
xml/System.Drawing.Imaging/EncoderParameters.xml ✅Succeeded View
xml/System.Drawing.Imaging/ImageAttributes.xml ✅Succeeded View
xml/System.Drawing.Imaging/ImageCodecInfo.xml ✅Succeeded View
xml/System.Drawing.Imaging/ImageFormat.xml ✅Succeeded View
xml/System.Drawing.Imaging/Metafile.xml ✅Succeeded View
xml/System.Drawing.Imaging/MetafileHeader.xml ✅Succeeded View
xml/System.Drawing.Imaging/PlayRecordCallback.xml ✅Succeeded View
xml/System.Drawing.Printing/PageSettings.xml ✅Succeeded View
xml/System.Drawing.Printing/PreviewPageInfo.xml ✅Succeeded View
xml/System.Drawing.Printing/PrintController.xml ✅Succeeded View
xml/System.Drawing.Printing/PrintDocument.xml ✅Succeeded View
xml/System.Drawing.Printing/PrintEventArgs.xml ✅Succeeded View
xml/System.Drawing.Printing/PrintEventHandler.xml ✅Succeeded View
xml/System.Drawing.Printing/PrintPageEventArgs.xml ✅Succeeded View
xml/System.Drawing.Printing/PrintPageEventHandler.xml ✅Succeeded View
xml/System.Drawing.Printing/PrinterSettings.xml ✅Succeeded View
xml/System.Drawing.Text/FontCollection.xml ✅Succeeded View
xml/System.Drawing.Text/InstalledFontCollection.xml ✅Succeeded View
xml/System.Drawing.Text/PrivateFontCollection.xml ✅Succeeded View
xml/System.Drawing/Bitmap.xml ✅Succeeded View
xml/System.Drawing/Brush.xml ✅Succeeded View
xml/System.Drawing/Brushes.xml ✅Succeeded View
xml/System.Drawing/BufferedGraphics.xml ✅Succeeded View
xml/System.Drawing/BufferedGraphicsContext.xml ✅Succeeded View
xml/System.Drawing/Font.xml ✅Succeeded View
xml/System.Drawing/FontConverter.xml ✅Succeeded View
xml/System.Drawing/FontFamily.xml ✅Succeeded View
xml/System.Drawing/Graphics.xml ✅Succeeded View
xml/System.Drawing/Icon.xml ✅Succeeded View
xml/System.Drawing/IconConverter.xml ✅Succeeded View
xml/System.Drawing/Image.xml ✅Succeeded View
xml/System.Drawing/ImageAnimator.xml ✅Succeeded View
xml/System.Drawing/Pen.xml ✅Succeeded View
xml/System.Drawing/Pens.xml ✅Succeeded View
xml/System.Drawing/Region.xml ✅Succeeded View
xml/System.Drawing/SolidBrush.xml ✅Succeeded View
xml/System.Drawing/StringFormat.xml ✅Succeeded View
xml/System.Drawing/SystemBrushes.xml ✅Succeeded View

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@gewarren gewarren removed the 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) label Aug 16, 2021
@gewarren gewarren marked this pull request as ready for review August 16, 2021 20:45
@gewarren
Copy link
Contributor Author

@BillWagner had previously approved #6944, so this just needs a very quick review.

@opbld34
Copy link

opbld34 commented Aug 16, 2021

Docs Build status updates of commit 6836abf:

✅ Validation status: passed

File Status Preview URL Details
includes/system-drawing-common.md ✅Succeeded View
xml/System.Drawing.Drawing2D/AdjustableArrowCap.xml ✅Succeeded View
xml/System.Drawing.Drawing2D/CustomLineCap.xml ✅Succeeded View
xml/System.Drawing.Drawing2D/GraphicsPath.xml ✅Succeeded View
xml/System.Drawing.Drawing2D/GraphicsPathIterator.xml ✅Succeeded View
xml/System.Drawing.Drawing2D/GraphicsState.xml ✅Succeeded View
xml/System.Drawing.Drawing2D/HatchBrush.xml ✅Succeeded View
xml/System.Drawing.Drawing2D/LinearGradientBrush.xml ✅Succeeded View
xml/System.Drawing.Drawing2D/Matrix.xml ✅Succeeded View
xml/System.Drawing.Drawing2D/PathGradientBrush.xml ✅Succeeded View
xml/System.Drawing.Imaging/Encoder.xml ✅Succeeded View
xml/System.Drawing.Imaging/EncoderParameter.xml ✅Succeeded View
xml/System.Drawing.Imaging/EncoderParameters.xml ✅Succeeded View
xml/System.Drawing.Imaging/ImageAttributes.xml ✅Succeeded View
xml/System.Drawing.Imaging/ImageCodecInfo.xml ✅Succeeded View
xml/System.Drawing.Imaging/ImageFormat.xml ✅Succeeded View
xml/System.Drawing.Imaging/Metafile.xml ✅Succeeded View
xml/System.Drawing.Imaging/MetafileHeader.xml ✅Succeeded View
xml/System.Drawing.Imaging/PlayRecordCallback.xml ✅Succeeded View
xml/System.Drawing.Printing/PageSettings.xml ✅Succeeded View
xml/System.Drawing.Printing/PreviewPageInfo.xml ✅Succeeded View
xml/System.Drawing.Printing/PrintController.xml ✅Succeeded View
xml/System.Drawing.Printing/PrintDocument.xml ✅Succeeded View
xml/System.Drawing.Printing/PrintEventArgs.xml ✅Succeeded View
xml/System.Drawing.Printing/PrintEventHandler.xml ✅Succeeded View
xml/System.Drawing.Printing/PrintPageEventArgs.xml ✅Succeeded View
xml/System.Drawing.Printing/PrintPageEventHandler.xml ✅Succeeded View
xml/System.Drawing.Printing/PrinterSettings.xml ✅Succeeded View
xml/System.Drawing.Text/FontCollection.xml ✅Succeeded View
xml/System.Drawing.Text/InstalledFontCollection.xml ✅Succeeded View
xml/System.Drawing.Text/PrivateFontCollection.xml ✅Succeeded View
xml/System.Drawing/Bitmap.xml ✅Succeeded View
xml/System.Drawing/Brush.xml ✅Succeeded View
xml/System.Drawing/Brushes.xml ✅Succeeded View
xml/System.Drawing/BufferedGraphics.xml ✅Succeeded View
xml/System.Drawing/BufferedGraphicsContext.xml ✅Succeeded View
xml/System.Drawing/Font.xml ✅Succeeded View
xml/System.Drawing/FontConverter.xml ✅Succeeded View
xml/System.Drawing/FontFamily.xml ✅Succeeded View
xml/System.Drawing/Graphics.xml ✅Succeeded View
xml/System.Drawing/Icon.xml ✅Succeeded View
xml/System.Drawing/IconConverter.xml ✅Succeeded View
xml/System.Drawing/Image.xml ✅Succeeded View
xml/System.Drawing/ImageAnimator.xml ✅Succeeded View
xml/System.Drawing/Pen.xml ✅Succeeded View
xml/System.Drawing/Pens.xml ✅Succeeded View
xml/System.Drawing/Region.xml ✅Succeeded View
xml/System.Drawing/SolidBrush.xml ✅Succeeded View
xml/System.Drawing/StringFormat.xml ✅Succeeded View
xml/System.Drawing/SystemBrushes.xml ✅Succeeded View

This comment lists only the first 50 files in the pull request.
For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@gewarren gewarren merged commit d139927 into dotnet:main Aug 16, 2021
@gewarren gewarren deleted the drawing-note branch August 16, 2021 21:51
@gewarren
Copy link
Contributor Author

Thank you @safern

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@safern safern safern approved these changes

@maryamariyan maryamariyan Awaiting requested review from maryamariyan

@merriemcgaw merriemcgaw Awaiting requested review from merriemcgaw merriemcgaw is a code owner

@michaelgsharp michaelgsharp Awaiting requested review from michaelgsharp

@RussKie RussKie Awaiting requested review from RussKie

@tarekgh tarekgh Awaiting requested review from tarekgh

Assignees
No one assigned
Labels
area-Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gewarren @opbld32 @opbld34 @safern