Skip to content

missing doc for HttpRequestOptions #7129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 10, 2021

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Sep 9, 2021

missing doc for HttpRequestOptions, HttpRequestOptionsKey and HttpRequestMessage.Options
Contributes to dotnet/runtime#43859
After this is merged, relevant runtime change is dotnet/runtime#58896

@ghost
Copy link

ghost commented Sep 9, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

missing doc for HttpRequestOptions, HttpRequestOptionsKey and HttpRequestMessage.Options
Contributes to dotnet/runtime#43859

Author: pavelsavara
Assignees: -
Labels:

area-System.Net.Http

Milestone: -

@pavelsavara pavelsavara changed the title missing doc for HttpRequestOptions, HttpRequestOptionsKey and HttpReq… missing doc for HttpRequestOptions Sep 9, 2021
@opbld30
Copy link

opbld30 commented Sep 9, 2021

Docs Build status updates of commit 908a206:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Http/HttpRequestMessage.xml ✅Succeeded View
xml/System.Net.Http/HttpRequestOptions.xml ✅Succeeded View
xml/System.Net.Http/HttpRequestOptionsKey`1.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@lewing lewing requested a review from pranavkm September 9, 2021 19:13
@pavelsavara
Copy link
Member Author

@carlossanlop @gewarren The generated preview for HttpRequestMessage shows obsolete Properties but not the new Options. Could you please help ?

@gewarren
Copy link
Contributor

gewarren commented Sep 9, 2021

@carlossanlop @gewarren The generated preview for HttpRequestMessage shows obsolete Properties but not the new Options. Could you please help ?

The preview link always defaults to the UWP moniker, for some reason. How does this look? https://review.docs.microsoft.com/en-us/dotnet/api/system.net.http.httprequestmessage?view=net-6.0&branch=pr-en-us-7129

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some suggestions.

Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change, @pavelsavara . Please merge after applying the suggestions provided by @gewarren.

Co-authored-by: Genevieve Warren <[email protected]>
@lewing lewing marked this pull request as ready for review September 10, 2021 03:58
@lewing lewing requested a review from a team as a code owner September 10, 2021 03:58
@opbld31
Copy link

opbld31 commented Sep 10, 2021

Docs Build status updates of commit a265def:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Http/HttpRequestMessage.xml ✅Succeeded View
xml/System.Net.Http/HttpRequestOptions.xml ✅Succeeded View
xml/System.Net.Http/HttpRequestOptionsKey`1.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@lewing lewing merged commit 753c32e into dotnet:net6-rc1 Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants