Skip to content

Not flowing dependency updates for Microsoft.NETCore.App #14501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
natemcmaster opened this issue Jan 24, 2019 · 4 comments · Fixed by #15703
Closed

Not flowing dependency updates for Microsoft.NETCore.App #14501

natemcmaster opened this issue Jan 24, 2019 · 4 comments · Fixed by #15703
Assignees
Milestone

Comments

@natemcmaster
Copy link
Contributor

This repo is only flowing dependency updates for packages, but not for the actually .NET Core runtime (Microsoft.NETCore.App). That means bot-generated PRs such as #14500 are not actually testing EFCore with the latest .NET Core.

The repo is currently using the runtime version that is baked into the .NET Core SDK. The SDK version is not automatically updated by Arcade, and even if it were, it would often be at least 1 step behind the latest runtime version which will be inserted into the SDK.

@bricelam @ajcvickers - was this an intentional change when converting this repo to Arcade?

@bricelam
Copy link
Contributor

Not intentional, but also ...meh.

lol, we’ll discuss. I’m certainly not against doing it.

@ajcvickers
Copy link
Contributor

And also turn by on warnings as errors.

@bricelam
Copy link
Contributor

bricelam commented Mar 5, 2019

I'm reverting this in #14643 (comment). It made things way too complicated.

@natemcmaster natemcmaster reopened this May 13, 2019
@natemcmaster
Copy link
Contributor Author

Re-opening. This is now blocking dependency flow for aspnetcore. See #15680

@bricelam bricelam removed this from the 3.0.0-preview3 milestone May 13, 2019
@bricelam bricelam added this to the 3.0.0 milestone May 14, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0, 3.0.0-preview6 Jun 5, 2019
@ajcvickers ajcvickers modified the milestones: 3.0.0-preview6, 3.0.0 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants