Add async infrastructure for lazy-loading #10904
Conversation
src/EFCore/Internal/LazyLoader.cs
Outdated
|
|
||
| return ShouldLoad(entity, navigationName, out var entry) | ||
| ? entry.LoadAsync(cancellationToken) | ||
| : Task.FromResult(0); |
There was a problem hiding this comment.
Is this something we should now do everywhere? (Currently we use .FromResult(0) throughout the stack, based on recommendation from @AndriySvyryd)
There was a problem hiding this comment.
Yeah, it may not have been around previously.
There was a problem hiding this comment.
Any is fine for now, it'll be cleaned up by #7445
| { | ||
| private readonly ICollection<LazyAsyncPsPost> _lazyAsyncPsPosts = new List<LazyAsyncPsPost>(); | ||
|
|
||
| private Func<object, CancellationToken, string, Task> LazyLoader { get; set; } |
There was a problem hiding this comment.
Flip CancellationToken and name parameters?
There was a problem hiding this comment.
We should discuss in API review--name is CallerMemberName which should also be last, and the signature of this func must currently match the signature of the method (since there is no manipulation of the order, etc. when building the expression tree.)
ajcvickers
force-pushed
the
BungleSaysPaintTheWholeWorldWithARainbow
branch
from
4ea4c00 to
76cb459
Compare
ajcvickers
force-pushed
the
BungleSaysPaintTheWholeWorldWithARainbow
branch
from
76cb459 to
7a0ad41
Compare
|
Thanks for doing that, it is a great API addition! |
Part of #10509, #3797
Adds ILazyLoader.LoadAsync and allows binding to delegate for it.