Add InvokeAsync with cancellation token overload to IJSRuntime #1915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveSandersonMS
approved these changes
Jul 2, 2019
ghost
deleted the
rynowak
reviewed
Jul 2, 2019
| /// <param name="args">JSON-serializable arguments.</param> | ||
| /// <param name="cancellationToken">A cancellation token to signal the cancellation of the operation.</param> | ||
| /// <returns>An instance of <typeparamref name="TValue"/> obtained by JSON-deserializing the return value.</returns> | ||
| Task<TValue> InvokeAsync<TValue>(string identifier, IEnumerable<object> args, CancellationToken cancellationToken = default); |
There was a problem hiding this comment.
What's the contract of this? Does providing a cancellation token override the default timeout? What if they pass default? Does that still override the timeout?
There was a problem hiding this comment.
- No cancellation token (params overload) uses the default timeout.
- Passing a cancellation token overrides the default timeout.
- Passing the default means no timeout
There was a problem hiding this comment.
Then this needs to be non-default parameter since the decision to pass a CT is really significant. There's a really important difference between these overloads.
There was a problem hiding this comment.
Fair enough, I'll send another PR
There was a problem hiding this comment.
I think we should get an ack from @GrabYourPitchforks as well (don't have to block on that).
There was a problem hiding this comment.
We can review that on the meeting next week.
JunTaoLuo
pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Feb 12, 2020
…t/extensions#1915) Adds the InvokeAsync with cancellation token overload to IJSRuntime\n\nCommit migrated from dotnet/extensions@55f0b77
JunTaoLuo
pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
Feb 15, 2020
…t/extensions#1915) Adds the InvokeAsync with cancellation token overload to IJSRuntime\n\nCommit migrated from dotnet/extensions@55f0b77
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.