Cleans up unused code #397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiercn
commented
Sep 21, 2018
| var matching = store.Certificates | ||
| .OfType<X509Certificate2>() | ||
| .Single(c => c.SerialNumber == certificate.SerialNumber); | ||
| .SingleOrDefault(c => c.SerialNumber == certificate.SerialNumber); |
There was a problem hiding this comment.
This was a bug that surfaced when the certificate was not trusted.
pranavkm
approved these changes
Sep 21, 2018
|
|
||
| try | ||
| { | ||
| store.Add(publicCertificate); |
davidfowl
reviewed
Sep 26, 2018
| bool isValid, | ||
| bool requireExportable = true) | ||
| bool requireExportable = true, | ||
| DiagnosticInformation diagnostics = null) |
javiercn
force-pushed
the
javiercn/diagnostics
branch
from
e635587 to
e2dfaeb
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a class and new methods to consume diagnostics from the tool and capture more detailed information on errors.