reactivate test - Help is displayed correctly #13792
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This testcase fell into the black hole that is outputwidth buffers.
For the longest time the most annoying tests we have are the fsharpqa tests that verify --help behavior. This test case was an attempt to improve on that.
However, it turns out that help text is always displayed as 80 on platforms that don't really support Console.BufferWidth (Linux and MacOS seem to return 0).
Windows is even more exciting, because it supports bufferwidth and we use it to format help text, when running tests on windows, success of this test depended on having the buffer size of the console running tests less than 80 chars wide.
Anyway ... enough of our problems. With this PR, we have added a testmode command line switch to the fsc and fsi that when specified sets the helptext formatting to the use the width value supplied in the option.
I also changed the printf of blockheaders
- OUTPUT FILES -
to use spaces rather than tabs, because updating baselines is easier.use
fsc.exe --bufferwidth:80 --nowarn:75 --help
to eliminate the warning message