Skip to content

Shorthand lambda: fix completion for chained calls #18560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
May 19, 2025
Merged

Shorthand lambda: fix completion for chained calls #18560

merged 16 commits into from
May 19, 2025

Conversation

DedSec256
Copy link
Contributor

Try to fix #18173

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 15, 2025 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/10.0.100.md

@DedSec256
Copy link
Contributor Author

DedSec256 commented May 16, 2025 •
edited
Loading

It is also fixes resolve, error range and message for the case

"" |> _.Length.

from random
Shorthand lambda syntax is only supported for atomic expressions, such as method, property, field or indexer ...
on the whole shorthand lambda with totally broken resolve inside

to Missing qualification after '.' at the last dot

@DedSec256 DedSec256 changed the title WIP Shorthand lambda: fix completion for chained calls Shorthand lambda: fix completion for chained calls May 16, 2025
@DedSec256 DedSec256 marked this pull request as ready for review May 16, 2025 17:18
@DedSec256 DedSec256 requested a review from a team as a code owner May 16, 2025 17:18
@DedSec256
Copy link
Contributor Author

There is a random infra failure :(
image

@vzarytovskii
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@DedSec256
nit
0fd489d 
it is better to return the same DiscardAfterMissingQualificationAfterDot instead of nested expression, just for consistency
@github-project-automation github-project-automation bot moved this from New to In Progress in F# Compiler and Tooling May 19, 2025
@T-Gro T-Gro merged commit a82b23d into dotnet:main May 19, 2025
33 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in F# Compiler and Tooling May 19, 2025
@DedSec256 DedSec256 deleted the ber.a/shortlambdafix branch May 19, 2025 15:06
This was referenced Jun 16, 2025
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vzarytovskii vzarytovskii vzarytovskii approved these changes

@edgarfgp edgarfgp edgarfgp approved these changes

@T-Gro T-Gro T-Gro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No IntelliSense for second dot of shorthand lambda syntax
4 participants
@DedSec256 @vzarytovskii @edgarfgp @T-Gro