Tests: introduce resolve and code completion contexts #18647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ No release notes required |
auduchinok
force-pushed
the
fcs-tests-checker
branch
3 times, most recently
from
5434a63 to
bba05f3
Compare
auduchinok
force-pushed
the
fcs-tests-checker
branch
from
bba05f3 to
7aa0c5c
Compare
|
It's ready 🙂 |
T-Gro
approved these changes
Jun 3, 2025
There was a problem hiding this comment.
I love this.
I only ever had to do a handful of a new completion/tooltip tests, but the test setup with the repetitive line of code entry, and having to manually adjust coordinates, was very annoying and hard to one-shot correctly.
I also believe the {caret} DSL now with the boilerplate removed will be easier for use also for non-humans :))
github-project-automation
bot
moved this from New
to In Progress
in F# Compiler and Tooling
This was referenced Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the manual context creation with locating a
{caret}mark in the source in more tests. It makes it much easier to write new editor-related tests and should also prevent mistakes that are easy to make when providing the context by hand. It continues the work started in #18524 and #18609.To make it easier to use the FCS APIs it introduces several new types:
SourceContext: contains info about the cursor position and the line textResolveContext: contains data needed for resolve-related features (getting a symbol, tooltip, overloads, etc)CodeCompletionContext: similar toResolveContextbut has code completion-specific differencesIt also introduces new
Checkermodule that provides test helpers for working with these new contexts. We may evolve these helpers into a newer FCS API in future, as it makes it significantly easier to work with these contexts than to provide things like the cursor coordinates separately.