Implement MethodImplOptions.AggressiveInlining flag - fixes #1637
#3154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dsyme @KevinRansom @kbattocchi I tried to find all places that were touched by NoInline but it's not working yet. Any ideas? |
dsyme
previously requested changes
Jun 16, 2017
src/fsharp/tast.fs
Outdated
| @@ -123,6 +125,7 @@ type ValFlags(flags:int64) = | |||
| (match inlineInfo with | |||
| | ValInline.PseudoVal -> 0b0000000000000000000L | |||
| | ValInline.Always -> 0b0000000000000010000L | |||
| | ValInline.Aggressive -> 0b0100L | |||
There was a problem hiding this comment.
This is not right - 0b0100L is already used by NormalVal above
src/fsharp/tast.fs
Outdated
| @@ -62,6 +62,8 @@ type ValInline = | |||
| | PseudoVal | |||
| /// Indicates the value is inlined but the .NET IL code for the function still exists, e.g. to satisfy interfaces on objects, but that it is also always inlined | |||
| | Always | |||
| /// Indicates the value will be inlined be inlined by the .NET runtime | |||
| | Aggressive | |||
There was a problem hiding this comment.
I'm not convinced we need to change the TAST (or Pickle) at all?
dsyme
changed the title
MethodImplOptions.AggressiveInlining flag - fixes #1637MethodImplOptions.AggressiveInlining flag - fixes #1637
|
@forki This is now ready but needs a test. Adding a code generation baseline test would make sense. Would you like to do that? thanks! |
|
Sorry in foreseeable future I won't have time to work on it. Cutting all F# OSS work down to minimum. Only stuff that is directly related to work blockers will survive.
|
Ok, I can add this one |
|
OK, test added, this is ready once green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MethodImplOptions.AggressiveInliningflag #1637