Skip to content

Only show retargeting dialog for .NetFramework projects #3206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2017

Conversation

joj
Copy link
Member

@joj joj commented Jun 13, 2017

There's several reasons for this, the most important being that only .NetFramework projects will provide a useful download. Also, not doing this resulted in a bug for Xamarin projects (Issue 2992). This fix is identical to what other projects do in Visual Studio.

/cc @cartermp

There's several reasons for this, the most important being that only .NetFramework projects will provide a useful download. Also, not doing this resulted in a bug for Xamarin projects (Issue 2992). This fix is identical to what other projects do in Visual Studio.
@msftclas
Copy link

@joj,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@cartermp
Copy link
Contributor

Thanks a bunch, @joj!

Copy link
Contributor

@KevinRansom KevinRansom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@KevinRansom KevinRansom merged commit 8d9b037 into dotnet:master Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants