Struct Records and Unions have ValueType super type #3208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm adding conformance tests to check that Nullable with struct records and unions compile correctly |
|
The NT Release ci part2 build is failing because the connection with the agent went offline: Appart from that, the PR seems ok. |
|
Now checks pass ! |
dsyme
approved these changes
Jun 15, 2017
|
LGTM - thanks @thinkbeforecoding ! |
|
Thanks again @thinkbeforecoding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #2609 .
It works with Nullable and the example with UnmanagedMemoryAccess from FileMappings I added in the comments.
I should probably add tests, but I'll need a hint to find where other tests on the topic can be found.