Skip to content

fix 1510: Static constructor interferes with ReflectedDefinition #3224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 20, 2017

Conversation

dsyme
Copy link
Contributor

@dsyme dsyme commented Jun 20, 2017

Fixes #1510

@dsyme
Copy link
Contributor Author

dsyme commented Jun 20, 2017

One failure:

1) Failed : FSharp-Tests-Core+CoreTests.reflect
Error running command 'D:\j\workspace\release_ci_pa---c6929ad7\tests\fsharp\..\..\Tools\dotnetcli\dotnet.exe' with args 'D:\j\workspace\release_ci_pa---c6929ad7\tests\fsharp\../testbin/release/coreclr/fsharp/core/reflect/test.exe' in directory 'D:\j\workspace\release_ci_pa---c6929ad7\tests\fsharp\core\reflect'. ERRORLEVEL -532462766
at TestFramework.checkResult(CmdResult result) in D:\j\workspace\release_ci_pa---c6929ad7\tests\fsharp\test-framework.fs:line 259
at [email protected](CmdResult result) in D:\j\workspace\release_ci_pa---c6929ad7\tests\fsharp\test-framework.fs:line 438
at SingleTest.singleTestBuildAndRunCore(TestConfig cfg, String copyFiles, Permutation p) in D:\j\workspace\release_ci_pa---c6929ad7\tests\fsharp\single-test.fs:line 64
at SingleTest.singleTestBuildAndRun(String dir, Permutation p) in D:\j\workspace\release_ci_pa---c6929ad7\tests\fsharp\single-test.fs:line 172

------

qcwowe932q OK
qcqmkee32al1 OK
qcqmkee32al2 OK
qcqmkee32ao OK
qcqmkee32ap OK
qcqmkee32aq OK
qcqmkee32ar OK
qcqmkee32ao1 OK
qcqmkee32ao2 OK
qcqmkee32ao3 OK
qcqmkee32ao4 OK
qcqmkee32ao5 OK
qcqmkee32ao6 OK

Unhandled Exception: System.ArgumentException: The record type 'Test+InternalRecordType1' is invalid. Required constructor is not defined.
   at Microsoft.FSharp.Reflection.Impl.getRecordConstructorMethod(Type typ, BindingFlags bindingFlags)
   at Microsoft.FSharp.Reflection.FSharpValue.PreComputeRecordConstructor(Type recordType, FSharpOption`1 bindingFlags)
   at <StartupCode$test>.$Test2.main@()

@KevinRansom KevinRansom merged commit 24e0588 into dotnet:master Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants