Skip to content

Fix 3118: quotation of struct union match #3227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 21, 2017
Merged

Fix 3118: quotation of struct union match #3227

merged 4 commits into from
Jun 21, 2017

Conversation

dsyme
Copy link
Contributor

@dsyme dsyme commented Jun 20, 2017

Fixes #3118

@dsyme dsyme mentioned this pull request Jun 20, 2017
Closed
3 tasks
@dsyme
Copy link
Contributor Author

dsyme commented Jun 20, 2017

Updated to also fix the second bug reported in #3118

@dsyme dsyme changed the title Fix quotation of struct union match Fix 3118: quotation of struct union match Jun 20, 2017
@dsyme
Copy link
Contributor Author

dsyme commented Jun 20, 2017

Two failures because of missing copy of System.ValueTuple.dll

1) Failed : FSharp-Tests-Core+CoreTests.quotes
Error running command 'C:\Program Files (x86)\Microsoft SDKs\Windows\v10.0A\bin\NETFX 4.6.2 Tools\peverify.exe' with args 'test.exe /nologo' in directory 'D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\core\quotes'. ERRORLEVEL 1
at TestFramework.checkResult(CmdResult result) in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\test-framework.fs:line 259
at [email protected](CmdResult result) in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\test-framework.fs:line 438
at [email protected](String path) in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\test-framework.fs:line 454
at FSharp-Tests-Core.CoreTests.quotes() in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\tests.fs:line 659

2) Failed : FSharp-Tests-Core+CoreTests.quotes-FSC-BASIC
Error running command 'C:\Program Files (x86)\Microsoft SDKs\Windows\v10.0A\bin\NETFX 4.6.2 Tools\peverify.exe' with args 'test--optplus--debug.exe /nologo' in directory 'D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\core\quotes'. ERRORLEVEL 1
at TestFramework.checkResult(CmdResult result) in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\test-framework.fs:line 259
at [email protected](CmdResult result) in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\test-framework.fs:line 438
at [email protected](String path) in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\test-framework.fs:line 454
at SingleTest.singleTestBuildAndRunCore(TestConfig cfg, String copyFiles, Permutation p) in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\single-test.fs:line 140
at SingleTest.singleTestBuildAndRun(String dir, Permutation p) in D:\j\workspace\release_ci_pa---866fd2c3\tests\fsharp\single-test.fs:line 172

@dsyme
Copy link
Contributor Author

dsyme commented Jun 20, 2017

now ready

@KevinRansom KevinRansom merged commit 385c8a3 into dotnet:master Jun 21, 2017
@stephen-swensen stephen-swensen mentioned this pull request Jun 26, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinRansom KevinRansom KevinRansom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsyme @KevinRansom @msftclas