Skip to content

Add fsharp.core build to proto #3230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 21, 2017
Merged

Conversation

KevinRansom
Copy link
Contributor

Proto build used an lkg for it's fsharp.core. This fixes that.
Also updates the lkg to the latest version of the F# compiler.

@KevinRansom
Copy link
Contributor Author

@dotnet-bot test Ubuntu14.04 Release Build please

@KevinRansom KevinRansom merged commit 8151842 into dotnet:master Jun 21, 2017
@dsyme
Copy link
Contributor

dsyme commented Jun 21, 2017

The one big thing that concerns me about this is that we have lost some test coverage for the compiler. If we insert a bug that affects the correct compilation of FSHarp.Core.dll, we won't detect it until much, much later when we adopt that compiler as the LKG. That could be after we've shipped the compiler to the world.

This isn't at all unlikely - FSharp.Core uses a number of features of the compiler that nothing else uses.

Could we still build the final FSharp.Core - the one we ship and test - with the proto compiler?

I understand that this change makes the logic of a from-source build easier. But there would be other ways to achieve that, wouldn't there, such as doing this conditionally?

@KevinRansom KevinRansom deleted the buildcoreinproto branch June 29, 2017 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants