inline raise and others #3239
Merged
inline raise and others #3239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forki
reviewed
Jun 22, 2017
| @@ -2189,7 +2189,7 @@ namespace Microsoft.FSharp.Core | |||
| /// <param name="x">The input value.</param> | |||
| /// <returns>The same value.</returns> | |||
| [<CompiledName("Identity")>] | |||
| val id : x:'T -> 'T | |||
| val inline id : x:'T -> 'T | |||
There was a problem hiding this comment.
that one is important ;-)
But would it be automatically inlined because of beta reduction?
There was a problem hiding this comment.
In optimized code all these are always inlined.
|
Failing codegen tests. Serves me right :) |
|
OK, this is ready |
KevinRansom
approved these changes
Jun 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address suggestion #3121
It is correct that the debugging experience is nicer if this is done. I've noticed this several times recently
We may as well mark a couple of other simple functions as "inline" too