Avoid boxing in Range equality comparisons #6048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
TIHan
approved these changes
Dec 22, 2018
|
This is great |
dsyme
reviewed
Jan 9, 2019
| @@ -56,6 +56,8 @@ val mkFileIndexRange : FileIndex -> pos -> pos -> range | |||
| /// This view hides the use of file indexes and just uses filenames | |||
| val mkRange : string -> pos -> pos -> range | |||
|
|
|||
| val equals : range -> range -> bool | |||
There was a problem hiding this comment.
Did you consider putting NoEquality and NoComparison on the range struct?
Also another option is to use open NonStructuralComparison more commonly, which at least flushes out places where structural comparison and equality are being used.
There was a problem hiding this comment.
I've considered doing it, just haven't gotten around to it yet :)
Seems like a fine thing to do
There was a problem hiding this comment.
So this is actually fairly icky work, but I have a branch that I'll throw up in PR at some point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces equality comparisons with ranges via
=and<>to use a new function,Range.equals. This function is the same as the overriddenEqualsmember. The reason is because=and<>on ranges actually end up boxing every range.