Skip to content

Update allowed binaries list#20689

Merged
marcpopMSFT merged 1 commit into
dotnet:release/8.0.1xxfrom
NikolaMilosavljevic:allowed.binaries
Nov 4, 2025
Merged

Update allowed binaries list#20689
marcpopMSFT merged 1 commit into
dotnet:release/8.0.1xxfrom
NikolaMilosavljevic:allowed.binaries

Conversation

@NikolaMilosavljevic

Copy link
Copy Markdown
Member

Fixes: dotnet/source-build#5391

All of these files are text files that are incorrectly flagged as binaries. The files are Unicode with a Unicode BOM. We already had exclusions for some other Unicode files. It is unclear why these files were suddenly flagged as binaries, but a likely suspect is the agent OS update to ubuntu-22.04.

This is not an issue in main or release/9.0.1xx as we use BinaryToolKit in those branches.

@NikolaMilosavljevic NikolaMilosavljevic requested a review from a team as a code owner October 29, 2025 16:42
@NikolaMilosavljevic NikolaMilosavljevic requested a review from a team October 29, 2025 16:42
@NikolaMilosavljevic

Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@NikolaMilosavljevic

Copy link
Copy Markdown
Member Author

Adding Servicing approved label as this is an infra change.

Adding Branch lockdown label - merge can happen on 11/4 the earliest.

@NikolaMilosavljevic

Copy link
Copy Markdown
Member Author

I think we could merge this today - checking - @marcpopMSFT

@marcpopMSFT marcpopMSFT merged commit 658dd2a into dotnet:release/8.0.1xx Nov 4, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants