Skip to content

[automated] Merge branch 'release/8.0.1xx' => 'release/8.0.4xx' #20782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimonZhao888 merged 3 commits into from
Jan 15, 2026
Merged

[automated] Merge branch 'release/8.0.1xx' => 'release/8.0.4xx' #20782

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5af40e0
Fix OmniSharp tests silently passing on script execution failures (#2…
mthalman Jan 14, 2026
0764653
Fix OmniSharp test failure (#20783)
mthalman Jan 14, 2026
07f9fa3
Merge branch 'release/8.0.4xx' into merge/release/8.0.1xx-to-release/…
SimonZhao888 Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions src/SourceBuild/content/test/Microsoft.DotNet.SourceBuild.SmokeTests/OmniSharpTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ public async void VerifyScenario(DotNetTemplate template)
string projectDirectory = DotNetHelper.ExecuteNew(templateName, projectName);

(Process Process, string StdOut, string StdErr) executeResult = ExecuteHelper.ExecuteProcess(
Path.Combine(OmniSharpDirectory, "run"),
$"-s {projectDirectory}",
DotNetHelper.DotNetPath,
$"{Path.Combine(OmniSharpDirectory, "OmniSharp.dll")} -- -s {projectDirectory}",
OutputHelper,
logOutput: true,
millisecondTimeout: 5000,
Expand All @@ -56,22 +56,21 @@ public async void VerifyScenario(DotNetTemplate template)
Assert.NotEqual(0, executeResult.Process.ExitCode);
Assert.DoesNotContain("ERROR", executeResult.StdOut);
Assert.DoesNotContain("ERROR", executeResult.StdErr);
Assert.DoesNotContain("command not found", executeResult.StdErr, StringComparison.OrdinalIgnoreCase);
Assert.DoesNotContain("No such file or directory", executeResult.StdErr, StringComparison.OrdinalIgnoreCase);
}

private async Task InitializeOmniSharp()
{
if (!Directory.Exists(OmniSharpDirectory))
{
using HttpClient client = new();
string omniSharpTarballFile = $"omnisharp-linux-{Config.TargetArchitecture}.tar.gz";
string omniSharpTarballFile = $"omnisharp-linux-{Config.TargetArchitecture}-net6.0.tar.gz";
Uri omniSharpTarballUrl = new($"https://github.com/OmniSharp/omnisharp-roslyn/releases/download/v{OmniSharpReleaseVersion}/{omniSharpTarballFile}");
await client.DownloadFileAsync(omniSharpTarballUrl, omniSharpTarballFile, OutputHelper);

Directory.CreateDirectory(OmniSharpDirectory);
Utilities.ExtractTarball(omniSharpTarballFile, OmniSharpDirectory, OutputHelper);

// Ensure the run script is executable (see https://github.com/OmniSharp/omnisharp-roslyn/issues/2547)
File.SetUnixFileMode($"{OmniSharpDirectory}/run", UnixFileMode.UserRead | UnixFileMode.UserExecute);
}
}
}