Update toolset to3.0.100-preview4.19110.1 #451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also there was an insertion 10 hours ago, why it is so old? |
nguerrera
approved these changes
Feb 11, 2019
|
Looks like last insertion of toolset was 10 days ago, not 10 hours ago! |
Per dotnet/fsharp#5882 This file is no longer needed and removed
wli3
commented
Feb 11, 2019
| @@ -146,6 +146,5 @@ | |||
|
|
|||
| <Exec Command="find $(SdkOutputDirectory) -type d -exec chmod 755 {} \;" /> | |||
| <Exec Command="find $(SdkOutputDirectory) -type f -exec chmod 644 {} \;" /> | |||
| <Chmod Mode="755" Glob="$(SdkOutputDirectory)/FSharp/RunFsc.sh" /> | |||
There was a problem hiding this comment.
@KevinRansom double check with you, we could remove this chmod right? per dotnet/fsharp#5882
There was a problem hiding this comment.
@wli3 yes. I confirm removing this is fine and necessary.
nguerrera
approved these changes
Feb 11, 2019
|
@mmitche any chance we forgot to turn the subscription back on after Preview2 shipped? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for dotnet/sdk#2867 a manual insertion