add LanguageName and LanguageVersion to KernelInfo #1908
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsequitur
force-pushed
the
kernel-language
branch
from
4ffc7c9 to
928ce19
Compare
colombod
reviewed
Mar 21, 2022
| @@ -8,8 +8,59 @@ | |||
| "language": "csharp" | |||
| } | |||
| }, | |||
| "outputs": [], | |||
There was a problem hiding this comment.
should not check in notebooks with output
There was a problem hiding this comment.
I've been thinking we should check in outputs but it's not something we've done systematically. It's a bit of a pain from a PR standpoint but it's also more useful as documentation. Thoughts?
There was a problem hiding this comment.
if output contains javascript github will block the rendering
There was a problem hiding this comment.
It will block rendering of the whole notebook? I know it won't run the JavaScript.
colombod
reviewed
Mar 21, 2022
colombod
reviewed
Mar 21, 2022
| <ItemGroup> | ||
| <Compile Include="..\Microsoft.DotNet.Interactive\Utility\InvocationContextExtensions.cs" Link="Utilities\InvocationContextExtensions.cs" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <None Remove="bin\Debug\netstandard2.1\/Microsoft.DotNet.Interactive.Journey.dll" /> |
There was a problem hiding this comment.
can't we use the tfm variable to exclude this?
colombod
reviewed
Mar 21, 2022
jonsequitur
force-pushed
the
kernel-language
branch
from
355fdf7 to
35a01b0
Compare
colombod
approved these changes
Mar 28, 2022
jonsequitur
force-pushed
the
kernel-language
branch
3 times, most recently
from
c0abff8 to
a9401fa
Compare
jonsequitur
force-pushed
the
kernel-language
branch
from
a9401fa to
8c9698e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.