enable input tokens in magic commands #1986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsequitur
changed the title
jonsequitur
force-pushed
the
user-input-in-magics
branch
from
ea2eed6 to
baaf8bb
Compare
jonsequitur
force-pushed
the
user-input-in-magics
branch
from
baaf8bb to
50a1c98
Compare
colombod
approved these changes
Apr 29, 2022
colombod
reviewed
May 3, 2022
colombod
reviewed
May 3, 2022
|
|
||
| public KernelCommandAndEventTextReaderReceiver(TextReader reader) | ||
| public KernelCommandAndEventTextStreamReceiver( | ||
| TextReader reader, |
There was a problem hiding this comment.
Why rename to TextStream if the input is still TextReader?
There was a problem hiding this comment.
Symmetry with the corresponding sender.
colombod
reviewed
May 3, 2022
| private readonly TextWriter _writer; | ||
|
|
||
| public KernelCommandAndEventTextStreamSender(TextWriter writer, Uri remoteHostUri) | ||
| public KernelCommandAndEventTextStreamSender( | ||
| TextWriter writer, |
There was a problem hiding this comment.
Same question here sender using a TextWriter but having TextStream in the name
colombod
added
Area-Polyglot Notebooks Extension
Area-Automation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will address #1554.