Add support for convention-based formatters #2053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsequitur
force-pushed
the
convention-based-formatter-registration
branch
from
53b4a8d to
1cbd6a6
Compare
3 tasks
colombod
added
Area-Formatting
colombod
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #1927 for the case of formatters. Using this approach, formatters can be registered from libraries that have no reference to Microsoft.DotNet.Interactive.Formatting, and therefore won't have assembly version conflicts with the version of Microsoft.DotNet.Interactive.Formatting that's packaged into
dotnet-interactive.