add support for RequestInput type hints and a file picker #2241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colombod
approved these changes
Aug 31, 2022
jonsequitur
force-pushed
the
input-type-hints-and-file-browser
branch
from
d68a7a0 to
0ec4844
Compare
AbhitejJohn
reviewed
Sep 2, 2022
| symbol switch | ||
| { | ||
| IValueDescriptor<DateTime> => "datetime-local", | ||
| IValueDescriptor<int> => "number", |
There was a problem hiding this comment.
Curious, how did we populate this list and how do we keep it updated with new types? I'm sure it's not the end of the world if this doesn't cover everything as well.
There was a problem hiding this comment.
#2245 makes this mechanism extensible.
AbhitejJohn
approved these changes
Sep 2, 2022
colombod
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for
RequestInputcommands to carry type hints based on the magic command parser's type expectations. One example is implemented here, which is triggering a file dialog when the expected type isFileSystemInfo: