#!import support in documents API
#2303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsequitur
requested review from
colombod and
brettfo
and removed request for
colombod
colombod
approved these changes
Sep 29, 2022
colombod
reviewed
Sep 29, 2022
| public static async Task<InteractiveDocument> LoadInteractiveDocumentAsync( | ||
| FileInfo file, | ||
| KernelInfoCollection kernelInfos) | ||
| public static async Task<InteractiveDocument> LoadAsync( |
There was a problem hiding this comment.
If LoadAsync expands / resolves the imports always could this cause a notebook parsing to inline the imported notebooks as we open a ipynb / dib in vscode?
There was a problem hiding this comment.
It doesn't resolve them or even try to identify them until someone calls GetImportsAsync.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support to
InteractiveDocumentfor reading documents linked via#!importmagic commands.