show help page if dotnet sdk version is insufficient #2482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user's SDK version wasn't sufficient an error toast is shown indicating that, but it can go unnoticed and isn't really actionable. This PR will show a rendered markdown file that is more visible, has more information, and has actionable links. Eventually this feature can be expanded to include a host of various fixes.
This will be particularly useful given that we're about to ship a version of the extension that will require a newer SDK.
Example:
Future work will be to detect multiple different issues and dynamically build a help page that can be used as a check list, but since the only issue we currently detect is a bad SDK, I opted to not add that complexity just yet.