Skip to content

change the logic to use sync API for shutdown #2891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2023
Merged

change the logic to use sync API for shutdown #2891

merged 1 commit into from
Apr 6, 2023

Conversation

shibbas
Copy link
Contributor

@shibbas shibbas commented Apr 6, 2023 •
edited
Loading

Address PR feedback from #2791 and instead doing a Wait on async API, do sync HTTP calls.

@colombod colombod merged commit e58e960 into dotnet:main Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colombod colombod colombod approved these changes

Assignees
No one assigned
Labels
Area-Jupyter subkernels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shibbas @colombod