js share by reference formatted values #3032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
17 tasks
jonsequitur
approved these changes
Jun 12, 2023
if is byref OR is not formatted value simplify condition proxykernel should not remove targetkernel name revert proxy kernel changes check is proxy remoteuri clean test
jonsequitur
reviewed
Jun 12, 2023
| @@ -494,6 +494,43 @@ public async Task value_option_is_required() | |||
| .Which.Message.Should().Be("Option '--value' is required."); | |||
| } | |||
|
|
|||
| [Fact] | |||
| public async Task ProxyKernels_can_share_values() | |||
There was a problem hiding this comment.
This test name should be more specific.
There was a problem hiding this comment.
this ProxyKernels_sharing_values_receives_them_as_deserialized_values
jonsequitur
reviewed
Jun 12, 2023
|
|
||
| ValueProduced valueProduced; | ||
| if ( | ||
| sourceKernel?.KernelInfo.IsProxy == false |
There was a problem hiding this comment.
I don't believe KernelInfo can ever be null.
There was a problem hiding this comment.
if the kernel is not found. that is the case when using @input:x
jonsequitur
reviewed
Jun 12, 2023
| @@ -383,6 +361,8 @@ ValueOptionResult ParseValueOption(ArgumentResult argResult) | |||
| isByref = false; | |||
| } | |||
|
|
|||
| var valueSourceKernel = destinationKernel.RootKernel.FindKernelByName(sourceValueName); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variable shared from js are now correctly parsed
