Skip to content

update extension messages for sdk install #3366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2023
Merged

update extension messages for sdk install #3366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/polyglot-notebooks-vscode-common/src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export async function activate(context: vscode.ExtensionContext) {

const dotnetConfig = vscode.workspace.getConfiguration(constants.DotnetConfigurationSectionName);
const polyglotConfig = vscode.workspace.getConfiguration(constants.PolyglotConfigurationSectionName);
const minDotNetSdkVersion = dotnetConfig.get<string>('minimumDotNetSdkVersion') || '7.0';
const minDotNetSdkVersion = dotnetConfig.get<string>('minimumDotNetSdkVersion') || '8.0';
const diagnosticsChannel = new OutputChannelAdapter(vscode.window.createOutputChannel('Polyglot Notebook : diagnostics'));
const loggerChannel = new OutputChannelAdapter(vscode.window.createOutputChannel('Polyglot Notebook : logger'));
DotNetPathManager.setOutputChannelAdapter(diagnosticsChannel);
Expand All @@ -98,13 +98,13 @@ export async function activate(context: vscode.ExtensionContext) {
const dotnetVersion = await getDotNetVersionOrThrow(DotNetPathManager.getDotNetPath(), diagnosticsChannel);
if (!isVersionGreaterOrEqual(dotnetVersion, minDotNetSdkVersion)) {
showHelpPage = true;
const message = `The .NET SDK version ${dotnetVersion} is not sufficient. The minimum required version is ${minDotNetSdkVersion}.`;
const message = `The .NET SDK version ${dotnetVersion} is not sufficient. The required version is ${minDotNetSdkVersion}.`;
diagnosticsChannel.appendLine(message);
vscode.window.showErrorMessage(message);
}
} catch (e) {
showHelpPage = true;
vscode.window.showErrorMessage(`Please install the .NET SDK version ${minDotNetSdkVersion} from https://dotnet.microsoft.com/en-us/download`);
vscode.window.showErrorMessage(`Please install the .NET SDK version ${minDotNetSdkVersion} from https://dotnet.microsoft.com/en-us/download/${minDotNetSdkVersion}`);
}

if (showHelpPage) {
Expand Down
6 changes: 3 additions & 3 deletions src/polyglot-notebooks-vscode-insiders/help/DotNetVersion.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# .NET 7 SDK **REQUIRED**
# .NET 8 SDK **REQUIRED**

## The Polyglot Notebooks extension now requires .NET SDK Version 8.0 or higher.
## The Polyglot Notebooks extension now requires .NET SDK Version 8.0.

## 1. Install [here](https://dotnet.microsoft.com/en-us/download)
## 1. Install [here](https://dotnet.microsoft.com/en-us/download/8.0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This URL is a 404.

## 2. Restart VS Code
6 changes: 3 additions & 3 deletions src/polyglot-notebooks-vscode/help/DotNetVersion.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# .NET 7 SDK **REQUIRED**
# .NET 8 SDK **REQUIRED**

## The Polyglot Notebooks extension now requires .NET SDK Version 8.0 or higher.
## The Polyglot Notebooks extension now requires .NET SDK Version 8.0.

## 1. Install [here](https://dotnet.microsoft.com/en-us/download)
## 1. Install [here](https://dotnet.microsoft.com/en-us/download/8.0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This URL is a 404.

## 2. Restart VS Code