Skip to content

Code cleanup #3574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Code cleanup #3574

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/Microsoft.DotNet.Interactive.CSharpProject/CSharpProjectKernel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,17 +276,13 @@ private async Task<Workspace> AppendCodeToWorkspaceAsync(string code, int positi

private static IEnumerable<Diagnostic> GetDiagnostics(string code, CompileResult result)
{
var diagnostics = Enumerable.Empty<SerializableDiagnostic>();

if (result.Features.TryGetValue(nameof(Diagnostics), out var candidateDiagnostics) &&
candidateDiagnostics is Diagnostics diags)
{
diagnostics = diags;
return diags.Select(d => new Diagnostic(new LinePositionSpan(GetLinePositionFromPosition(code, d.Start), GetLinePositionFromPosition(code, d.End)), d.Severity, d.Id, d.Message));
}

var finalDiagnostics = diagnostics.Select(d => new Diagnostic(new LinePositionSpan(GetLinePositionFromPosition(code, d.Start), GetLinePositionFromPosition(code, d.End)), d.Severity, d.Id, d.Message));

return finalDiagnostics;
return Enumerable.Empty<Diagnostic>();
}

private void ThrowIfProjectIsNotOpened()
Expand Down