Skip to content

Fix issue with $localDatetime using UTC. #3626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 6, 2024
Merged

Fix issue with $localDatetime using UTC. #3626

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cc195f0
Fix issue with $localDatetime using UTC.
phenning Aug 5, 2024
614d9d6
Add tests to verify we are using .UtcNow vs .Now, as appropraite.
phenning Aug 6, 2024
f8fb9ca
remove extraneous ToStrings()
phenning Aug 6, 2024
f049f20
Remove unneeded AssertionScopes
phenning Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions src/Microsoft.DotNet.Interactive.Http.Tests/ParserTests.DynamicExpressions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,25 @@ public void can_bind_datetime_with_custom_format()
binding.Value.As<string>().Should().Be(currentTime.AddDays(1.0).ToString("dd-MM-yyyy").ToString());
}

[Fact]
public void can_bind_datetime_uses_utcnow()
{
using var _ = new AssertionScope();

var expression = "$datetime 'Tzz'";
var code = $@"@var = {{{{{expression}}}}}";

var result = HttpRequestParser.Parse(code);
var currentTime = DateTimeOffset.UtcNow;
var node = result.SyntaxTree.RootNode.DescendantNodesAndTokens().OfType<HttpExpressionNode>().Single();

// Since we want to make sure that the provided expression is evaluated
// and .Now or .UtcNow is used as appropriate, we do not pass our own offset, like we do with other unit tests.
// we can do this since we are passing a custom format which only includes the time zone.
var binding = DynamicExpressionUtilities.ResolveExpressionBinding(node, expression);
binding.Value.As<string>().Should().Be(currentTime.ToString("Tzz").ToString());
}

[Fact]
public void can_bind_datetime_with_iso8601_format()
{
Expand Down Expand Up @@ -110,6 +129,25 @@ public void can_bind_local_datetime_with_custom_format()
binding.Value.As<string>().Should().Be(currentTime.AddDays(1.0).ToString("dd-MM-yyyy").ToString());
}

[Fact]
public void can_bind_local_datetime_uses_now()
{
using var _ = new AssertionScope();

var expression = "$localDatetime 'Tzz'";
var code = $@"@var = {{{{{expression}}}}}";

var result = HttpRequestParser.Parse(code);
var currentTime = DateTimeOffset.Now;
var node = result.SyntaxTree.RootNode.DescendantNodesAndTokens().OfType<HttpExpressionNode>().Single();

// Since we want to make sure that the provided expression is evaluated
// and .Now or .UtcNow is used as appropriate, we do not pass our own offset, like we do with other unit tests.
// we can do this since we are passing a custom format which only includes the time zone.
var binding = DynamicExpressionUtilities.ResolveExpressionBinding(node, expression);
binding.Value.As<string>().Should().Be(currentTime.ToString("Tzz").ToString());
}

[Fact]
public void can_bind_local_datetime_with_iso8601_format()
{
Expand Down