Skip to content

consolidate JsonConverter<T>, make it and derived types internal #3635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 10, 2024
Merged

consolidate JsonConverter<T>, make it and derived types internal #3635

merged 1 commit into from
Aug 10, 2024

Conversation

jonsequitur
Copy link
Contributor

These types don't need to be public so I've made them internal and linked files to remove redundant copies of JsonConverter<T>.

@jonsequitur jonsequitur enabled auto-merge (rebase) August 9, 2024 20:08
@jonsequitur jonsequitur merged commit ea5e4bb into dotnet:main Aug 10, 2024
4 checks passed
@jonsequitur jonsequitur deleted the clean-up-JsonConverter-and-derivatives branch August 21, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shyamnamboodiripad shyamnamboodiripad shyamnamboodiripad approved these changes

@colombod colombod Awaiting requested review from colombod

Assignees
No one assigned
Labels
Area-Messaging / scheduling / comms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonsequitur @shyamnamboodiripad