add descriptions and icons to kernel chooser quickpick #3754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -25,6 +25,9 @@ public KqlDiscoverabilityKernel() : base(DefaultKernelName) | |||
| "MsKqlKernel" | |||
| }; | |||
| KernelInfo.LanguageName = "KQL"; | |||
| KernelInfo.Description = $""" | |||
| Query a Kusto database | |||
| """; | |||
There was a problem hiding this comment.
nit: Indents - not sure whether this will end up including extra whitespace in the literal (does it?)
|
|
||
| // const allItems = [...kernelSelectorItems, | ||
| // { description: '', label: '', kind: vscode.QuickPickItemKind.Separator }, | ||
| // ...mruConnectionItems]; |
There was a problem hiding this comment.
Can the commented lines be removed?
There was a problem hiding this comment.
It's working code and will be back in the next PR. Not sure it's worth a do-over on the CI run but I'll do it if this CI run hits any issues.
shyamnamboodiripad
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some detail to the kernel chooser as shown in the image below. As part of this, I've simplified the kernel descriptions.