Skip to content

Conversation

jonsequitur
Copy link
Contributor

@jonsequitur jonsequitur commented Feb 23, 2025

These changes fix the following issues:

This is a work in progress and additional PRs will continue to investigate and address some of the FIX comments present here but this is likely worth merging in order to do a preview release and validate the changes against a larger number of existing notebook documents than the tests likely account for. I anticipate that some of these changes will break backwards compatibility for metadata variations that date back to before the VS Code notebook APIs were finalized. I don't believe it's practical to support those forever, and any notebooks that are broken as a result will at this point be far fewer than the impact of these bugs on newer and newly-created notebooks.

These changes fix the issue of outputs disappearing when opening a notebook and also .ipynb files immediately being marked dirty on open. That issue is still present for .dib files.
@jonsequitur jonsequitur merged commit 59dbbfb into dotnet:main Feb 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants