Hide overridden JLO machinery from editor #688
Labels
enhancement
Proposed change to current functionality
generator
Issues binding a Java library (generator, class-parse, etc.)
Comments
jpobst
added
enhancement
jonpryor
pushed a commit
that referenced
this issue
Aug 28, 2020
Fixes: #688 Context: dotnet/android#4582 Context: dotnet/android@3c94f6f Context: dotnet/android#4582 (comment) In dotnet/android#4582 we hid "infrastructural" members like `Java.Lang.Object.ThresholdClass` from the editor and debugger using `[DebuggerBrowsable(DebuggerBrowsableState.Never)]` and `[EditorBrowsable(EditorBrowsableState.Never)]`. However, `generator` output overrides these members, and thus they're *still* visible from the IDE editor and debugger. In order to *fully* hide infrastructural members from the editor and debugger, *every occurrence* of the member must also have `DebuggerBrowsableAttribute` and `EditorBrowsableAttribute`! Update `generator` so that all infrastructural members contain the attributes necessary to hide them from code completion, e.g. [global::System.Diagnostics.DebuggerBrowsable (global::System.Diagnostics.DebuggerBrowsableState.Never)] [global::System.ComponentModel.EditorBrowsable (global::System.ComponentModel.EditorBrowsableState.Never)] public override global::Java.Interop.JniPeerMembers JniPeerMembers { get { return _members; } } This ensures that the members are in fact hidden from IDEs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In dotnet/android#4582 we hid "internal" methods like
Java.Lang.Object.ThresholdClassfrom the editor and debugger using[DebuggerBrowsable (DebuggerBrowsableState.Never)]and[EditorBrowsable (EditorBrowsableState.Never)]. However our bindings override some of these methods/properties and need to also apply these attributes or else they still show up in IDEs.The text was updated successfully, but these errors were encountered: