[Java.Interop.Tools.TypeNameMappings] fix trimmer warnings #1194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpeppers
force-pushed
the
Java.Interop.Tools.TypeNameMappings
branch
from
81405c2 to
9ac0133
Compare
jonathanpeppers
commented
Feb 16, 2024
| <AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath> | ||
| <LangVersion>8.0</LangVersion> | ||
| <Nullable>enable</Nullable> | ||
| <AllowUnsafeBlocks>true</AllowUnsafeBlocks> | ||
| <SignAssembly>true</SignAssembly> | ||
| <ProduceReferenceAssembly>true</ProduceReferenceAssembly> |
There was a problem hiding this comment.
The net8.0 build failed without this:
Which is kind of odd, I thought that was the default in net5.0+? We should use it anyway to make incremental builds quicker.
jonathanpeppers
commented
Feb 16, 2024
....Interop.Tools.TypeNameMappings/Java.Interop.Tools.TypeNameMappings/JavaNativeTypeManager.cs
Outdated
Show resolved
Hide resolved
Context: https://github.com/xamarin/xamarin-android/blob/e987ac458536e59a8329a06d5c5d5f4d4ea2c6b6/src/Mono.Android/Mono.Android.csproj#L69-L71 In xamarin/xamarin-android, we import the source for `Java.Interop.Tools.TypeNameMappings\JavaNativeTypeManager.cs`, and unfortunately there are some trimmer warnings: external\Java.Interop\src\Java.Interop.Tools.TypeNameMappings\Java.Interop.Tools.TypeNameMappings\JavaNativeTypeManager.cs(182,9): error IL2070: 'this' argument does not satisfy 'DynamicallyAccessedMemberTypes.Interfaces' in call to 'System.Type.GetInterfaces()'. The parameter 'type' of method 'Java.Interop.Tools.TypeNameMappings.JavaNativeTypeManager.ToJniName(Type, ExportParameterKind)' does not have matching annotations. The source value must declare at least the same requirements as those declared on the target location it is assigned to. From the code: if (!type.GetInterfaces ().Any (t => t.FullName == "Android.Runtime.IJavaObject")) It appears we can instead look for `IJavaPeerable` and use trim-safe behavior instead: if (Type.GetType ("Java.Interop.IJavaPeerable, Java.Interop", throwOnError: true) .IsAssignableFrom (type)) I also cached the `Type.GetType()` call with `Lazy<T>`. However, in some cases we run this code under an MSBuild context. In this case, we don't have `Java.Interop.dll` to load, so we should instead use: type.GetInterfaces ().Any (t => t.FullName == "Java.Interop.IJavaPeerable"); To catch warnings in this project going forward: * Multi-target to `netstandard2.0` and `net8.0` using `$(DotNetTargetFramework)`. `netstandard2.0` is used for MSBuild-task assemblies inside VS. * Enable trimmer warnings for `net8.0` As I targeted `net8.0`, various null-reference-type warnings appeared, which I also fixed.
jonathanpeppers
force-pushed
the
Java.Interop.Tools.TypeNameMappings
branch
from
6845af4 to
889057c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://github.com/xamarin/xamarin-android/blob/e987ac458536e59a8329a06d5c5d5f4d4ea2c6b6/src/Mono.Android/Mono.Android.csproj#L69-L71
In xamarin/xamarin-android, we import the source for
Java.Interop.Tools.TypeNameMappings\JavaNativeTypeManager.cs, and unfortunately there are some trimmer warnings:From the code:
It appears we can instead look for
IJavaPeerableand use trim-safe behavior instead:I also cached the
Type.GetType()call withLazy<T>.However, in some cases we run this code under an MSBuild context. In
this case, we don't have
Java.Interop.dllto load, so we shouldinstead use:
To catch warnings in this project going forward:
Multi-target to
netstandard2.0andnet8.0using$(DotNetTargetFramework).netstandard2.0is used for MSBuild-task assemblies inside VS.Enable trimmer warnings for
net8.0As I targeted
net8.0, various null-reference-type warnings appeared, which I also fixed.