[build] remove XAIntegrationDebug and XAIntegrationRelease #361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpeppers
force-pushed
the
remove-xaintegrationdebug
branch
from
158e2d6 to
def00eb
Compare
In PR: dotnet#360 I will likely add a new `$(Configuration)` to be used in xamarin-android, so we can build `Java.Interop` as a non-PCL. The existence of `XAIntegrationDebug` and `XAIntegrationRelease` are confusing, since they are no longer used. See: dotnet@54a2aff dotnet/android#1231 This removes `XAIntegrationDebug` and `XAIntegrationRelease` from all solutions, project files, and `Makefile`. I also let VS 2017 update the SLN file, as it was an old VS 2010 format...
jonathanpeppers
force-pushed
the
remove-xaintegrationdebug
branch
from
def00eb to
0ce91c0
Compare
dellis1972
approved these changes
Aug 24, 2018
|
Looks ok. Its not being used any where. |
jonathanpeppers
added a commit
to jonathanpeppers/xamarin-android
that referenced
this pull request
Aug 25, 2018
Context: dotnet/java-interop@78f7301...893562c Use JdkInfo during the build: dotnet/java-interop#349 Optimize type lookups: dotnet/java-interop#350 [jnimarshalmethod-gen] --types option: dotnet/java-interop@d174fa6 Remove unused XAIntegration $(Configuration): dotnet/java-interop#361 Option to build Java.Interop as non-PCL: dotnet/java-interop#360
dellis1972
pushed a commit
to dotnet/android
that referenced
this pull request
Aug 26, 2018
Context: dotnet/java-interop@78f7301...893562c Use JdkInfo during the build: dotnet/java-interop#349 Optimize type lookups: dotnet/java-interop#350 [jnimarshalmethod-gen] --types option: dotnet/java-interop@d174fa6 Remove unused XAIntegration $(Configuration): dotnet/java-interop#361 Option to build Java.Interop as non-PCL: dotnet/java-interop#360
jonathanpeppers
added a commit
to jonathanpeppers/java.interop
that referenced
this pull request
Sep 7, 2018
In PR: dotnet#360 I will likely add a new `$(Configuration)` to be used in xamarin-android, so we can build `Java.Interop` as a non-PCL. The existence of `XAIntegrationDebug` and `XAIntegrationRelease` are confusing, since they are no longer used. See: dotnet@54a2aff dotnet/android#1231 This removes `XAIntegrationDebug` and `XAIntegrationRelease` from all solutions, project files, and `Makefile`. I also let VS 2017 update the SLN file, as it was an old VS 2010 format...
jonpryor
pushed a commit
that referenced
this pull request
Sep 10, 2018
Context: dotnet/android#2157 We believe that we need commit 80b4f4e -- which removes the `XAIntegrationDebug` and `XAIntegrationRelease` configurations -- applied to xamarin/Java.Interop:d15-9 so that xamarin/xamarin-android:d15-9 will actually build.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR: #360
I will likely add a new
$(Configuration)to be used inxamarin-android, so we can build
Java.Interopas a non-PCL.The existence of
XAIntegrationDebugandXAIntegrationReleaseareconfusing, since they are no longer used.
See:
54a2aff
dotnet/android#1231
This removes
XAIntegrationDebugandXAIntegrationReleasefrom allsolutions, project files, and
Makefile.I also let VS 2017 update the SLN file, as it was an old VS 2010
format...