Skip to content

[Java.Interop] Revert removing public constructor from abstract class to appease api checker. #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2019

Conversation

jpobst
Copy link
Contributor

@jpobst jpobst commented Nov 26, 2019

We removed the public constructor from abstract class Java.Interop.JniRuntime.JniObjectReferenceManager in #523. This change is fine, but it triggered the API Compatibility check.

Because we are in the middle of replacing that check with something else it's easier to simply revert this change for now.

@jonpryor jonpryor merged commit e7d96f2 into master Nov 26, 2019
@jonpryor jonpryor deleted the public-ctor branch November 26, 2019 15:48
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants