Skip to content

[generator] Bind protected nested types. #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2020
Merged

[generator] Bind protected nested types. #578

merged 1 commit into from
Feb 21, 2020

Conversation

jpobst
Copy link
Contributor

@jpobst jpobst commented Feb 21, 2020

In #575, we stopped binding nested types that are not public or internal, however we also need to bind nested types that are protected.

Note that internally protected is stored as protected internal due to:

https://github.com/xamarin/java.interop/blob/master/tools/generator/Java.Interop.Tools.Generator.Importers/XmlApiImporter.cs#L143-L144

@jpobst jpobst requested a review from jonpryor February 21, 2020 15:46
@jonpryor jonpryor merged commit cd33da6 into master Feb 21, 2020
@jonpryor jonpryor deleted the bind-protected branch February 21, 2020 18:02
jonpryor pushed a commit that referenced this pull request Feb 24, 2020
In commit fa10e98, we stopped binding nested types that are **not**
`public` or `internal`.

However, we also need to bind nested types that are `protected`.

Note that internally `protected` is stored as `protected internal`:

	https://github.com/xamarin/java.interop/blob/fa10e98bb42a92229281056cf3e74d0576f4d9f8/tools/generator/Java.Interop.Tools.Generator.Importers/XmlApiImporter.cs#L143-L144
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants