[generator] Bind protected nested types. #578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpobst
force-pushed
the
bind-protected
branch
from
bf76dc0 to
8a44bbd
Compare
jonpryor
pushed a commit
that referenced
this pull request
Feb 24, 2020
In commit fa10e98, we stopped binding nested types that are **not** `public` or `internal`. However, we also need to bind nested types that are `protected`. Note that internally `protected` is stored as `protected internal`: https://github.com/xamarin/java.interop/blob/fa10e98bb42a92229281056cf3e74d0576f4d9f8/tools/generator/Java.Interop.Tools.Generator.Importers/XmlApiImporter.cs#L143-L144
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #575, we stopped binding nested types that are not
publicorinternal, however we also need to bind nested types that areprotected.Note that internally
protectedis stored asprotected internaldue to:https://github.com/xamarin/java.interop/blob/master/tools/generator/Java.Interop.Tools.Generator.Importers/XmlApiImporter.cs#L143-L144