[Java.Interop] Fix C# warnings. #652
Conversation
jpobst
changed the title
| @@ -48,8 +48,8 @@ partial class CreationOptions { | |||
| var t = jie.GetType ("Java.Interop.MarshalMemberBuilder"); | |||
| if (t == null) | |||
| throw new InvalidOperationException ("Could not find Java.Interop.MarshalMemberBuilder from Java.Interop.Export.dll!"); | |||
| var b = (JniMarshalMemberBuilder) Activator.CreateInstance (t); | |||
| marshalMemberBuilder = SetRuntime (b); | |||
| var b = (JniMarshalMemberBuilder?) Activator.CreateInstance (t); | |||
There was a problem hiding this comment.
Not sure I understand this change, as Activator.CreateInstance() is only documented as returning null when type is a Nullable<T>, which won't be the case here.
There was a problem hiding this comment.
I guess I prefer the approach taken later in this PR:
var b = (JniMarshalMemberBuilder) Activator.CreateInstance (t)!;
| @@ -87,7 +87,7 @@ public Delegate CreateMarshalToM | |||
| { | |||
| if (value == null) | |||
| throw new ArgumentNullException (nameof (value)); | |||
| return CreateMarshalToManagedExpression (value.GetMethodInfo ()).Compile (); | |||
| return CreateMarshalToManagedExpression (value.GetMethodInfo ()!).Compile (); | |||
There was a problem hiding this comment.
.GetMethodInfo() can return null?!
Are the NRT annotations in mscorlib.dll "final" (or "sane")?
There was a problem hiding this comment.
Looks like this was fixed in a later version, I'll take the change out and assume we will eventually be on the same version as dotnet: dotnet/runtime@505341d.
| @@ -291,7 +290,7 @@ static unsafe JavaVMInterface CreateInvoker (IntPtr handle) | |||
| public virtual void FailFast (string? message) | |||
| { | |||
| var m = typeof (Environment).GetMethod ("FailFast"); | |||
| m.Invoke (null, new object?[]{ message }); | |||
| m?.Invoke (null, new object?[]{ message }); | |||
There was a problem hiding this comment.
This is a "FailFast" invocation. If m is null, for whatever reason, it should throw.
Or, we should add a Environment.Exit() or something on the following line.
The intent here is "the VM is hosed; we need to die"
|
Addressed feedback. |
Fixes 43 Nullable Reference Type warnings Fixes CS0168 warning: The variable 'e' is declared but never used. Fixes 6 CA1307 warnings introduced by targeting `netcoreapp3.1`: The behavior of 'string.IndexOf(char)' could vary based on the current user's locale settings.
CS0168warning: (The variable 'e' is declared but never used)CA1307warnings introduced by targetingnetcoreapp3.1. (The behavior of 'string.IndexOf(char)' could vary based on the current user's locale settings.)