[generator] Clean up generated whitespace. #692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpobst
force-pushed
the
test-whitespace
branch
4 times, most recently
from
8d53ef0 to
77af877
Compare
jpobst
force-pushed
the
test-whitespace
branch
from
77af877 to
9ee9225
Compare
jpobst
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent
generatorrefactor (#674) caused there to be differences in how whitespace is generated in bindings. In order to minimize distractions in an already hard to review PR, the test infrastructure was changed to ignore whitespace differences. This made it possible to ensure there were no non-whitespace changes caused by the refactor.This PR cleans up the generated whitespace to be closer to the original.
Note that the test diffs weren't updated when the original
generatorrefactor was committed (to keep the PR slightly more readable). Thus the test expected output changes in this PR are not caused by the code changes in this PR, they already exist inmaster. The code changes in this PR cause there to be fewer test diffs than there would be, by making our output closer to the pre-refactor version.