Skip to content

[generator] Provide line/col numbers for api.xml warnings. #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2020

Conversation

jpobst
Copy link
Contributor

@jpobst jpobst commented Sep 15, 2020

Today, when you get a warning while trying to bind an api.xml file, no source information is provided:

BINDINGSGENERATOR : warning BG8700: Unknown return type 'com.blah.a.a.a.a' for member 
'Com.Blah.Foo.Sdk.LoggerGetUserLogger ()'. [C:\code\temp\Blah\Blah.csproj]

We can make the user experience a tiny bit nicer by adding the file name and line/col information in standard MSBuild format. This allows users to double click the error in VS and be taken directly to the correct location in the api.xml file:

BINDINGSGENERATOR : obj\Debug\api.xml(1684, 8) warning BG8700: Unknown return type 'com.blah.a.a.a.a' 
for member 'Com.Blah.Foo.Sdk.LoggerGetUserLogger ()'. [C:\code\temp\Blah\Blah.csproj]

@jpobst jpobst marked this pull request as ready for review September 15, 2020 19:20
@jonpryor jonpryor merged commit b858dc5 into master Sep 18, 2020
@jonpryor jonpryor deleted the api-xml-line-numbers branch September 18, 2020 00:52
@jpobst jpobst added this to the 11.1 (16.9 / 8.9) milestone Sep 22, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants