[jnimarshalmethod-gen] Avoid creating AppDomains #720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is part of making the tool to work on Windows and later also with NET5. The created `AppDomain` was used to isolate processed assembly, so that we can unload it and rewrite with generated changes. That didn't work on Windows even with .NET framework, which has the AppDomains API. In NET5 the creation of AppDomains is not even part of the API. So instead of using the created `AppDomain`'s, we preload the assembly in memory and load it from there.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of making the tool to work on Windows and later also with
NET5. The created
AppDomainwas used to isolate processed assembly,so that we can unload it and overwrite it with generated changes.
That didn't work on Windows even with .NET framework, which has
the
AppDomains API. In NET5 the creation of AppDomains is not evenpart of the API.
So instead of using the created
AppDomains, we preload the assemblyin memory and load it from there.