[Bytecode] Hide nested types inside hidden Kotlin types. #723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpryor
pushed a commit
that referenced
this pull request
Sep 18, 2020
Fixes: #682 Context: dotnet/android#4955 We added support for reading Kotlin-provided metadata in commit 439bd83. Part of this was recognizing when a type was "Kotlin-internal" and marking it as `private` or "package-private" to prevent `generator` from attempting to bind it. However, we didn't consider *nested* types of `private` or "package-private" types in 439bd83, leaving the nested type visibility unchanged. This could result in a warning when binding such nested types: warning BG8604: top ancestor ParentType not found for nested type ParentType.ChildEnum Note: this doesn't prevent building -- unless `csc /warnaserror` is used -- and the type is not bound, so we are doing the "correct" thing. This warning *does* create a "less-than-desirable" user experience, possibly confusing users. Update `generator` to change the visibility of nested types within non-`public` types so that `generator` doesn't attempt to bind the nested types. This avoids the BG8604 warning.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #682
Context: dotnet/android#4955
Previously, we added support for reading Kotlin generated metadata. Part of this was recognizing when a type was "Kotlin-internal" and marking it
private/package-privatesogeneratorwould not attempt to bind it.However we did not modify nested types of these types, which still show as
public. When attempting to bind these, the parent type cannot be found which causes a warning:Note this doesn't prevent building, and the type is not bound, so we are doing the "correct" thing. This fix just prevents the warning from appearing, possibly confusing users.
The fix is to mark all nested types the same level of "hidden" as the parent type.