[java-source-utils] Add response file support #744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for ["response files"][0] to `java-source-utils.jar`, allowing `java-source-utils.jar` options to be present within a plain- text file, and the file provided as an option: $ cat >response-file <<EOF --help EOF $ java -jar java-source-utils.jar @response-file # equivalent to: java -jar java-source-utils.jar --help In this case, the "scare quotes" is because of limitations when parsing the response file: only one value per line. Blank lines are ignored, as are lines starting with `#`. Thus, a response file with contents: --source /path/to/source/directory is fine, while a response file with the contents: --source /path/to/source/directory will not be parsed properly. [0]: https://docs.microsoft.com/en-us/windows/win32/midl/response-files
jpobst
approved these changes
Oct 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for "response files" to
java-source-utils.jar,allowing
java-source-utils.jaroptions to be present within a plain-text file, and the file provided as an option:
In this case, the "scare quotes" is because of limitations when
parsing the response file: only one value per line. Blank lines are
ignored, as are lines starting with
#.Thus, a response file with contents:
is fine, while a response file with the contents:
will not be parsed properly.