[ci] Make VC++ toolchain optional #820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet/android#5757 Turns Out™ that the xamarin-android Windows CI machine *doesn't* have Visual C++ installed, and thus *can't* build `src/java-interop` with the changes in 3824b97. (Rephrased: 3824b97 broke the Windows build for xamarin-android!) Update `NativeToolchain.targets`, `src/java-interop`, and `tests/NativeTiming` so that native files are *optional* when building on Windows. This should allow xamarin-android CI to work.
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Mar 22, 2021
Context: dotnet/java-interop#820 Context: dotnet#5757 Does It Build™?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/android#5757
Turns Out™ that the xamarin-android Windows CI machine doesn't have
Visual C++ installed, and thus can't build
src/java-interopwiththe changes in 3824b97. (Rephrased: 3824b97 broke the Windows
build for xamarin-android!)
Update
NativeToolchain.targets,src/java-interop, andtests/NativeTimingso that native files are optional when buildingon Windows. This should allow xamarin-android CI to work.